chrismorgan 7 hours ago

> In the above example, on every loop, the += operator causes a new string to be allocated, and the content to be copied, which gets exponentially more expensive as the string grows.

But that’s only the theoretical behaviour. In practice, languages tend to end up optimising it in various ways. As noted a paragraph later, the Java compiler is able to detect and “fix” this, by rewriting the code to use a mutable string.

Another solution is to put concatenation into your string type as another possible representation. I believe at least some (no idea if it’s all) JavaScript engines do this. You end up with something like this (expressed in Rust syntax, and much simpler than the real ones are):

  enum String {
      Latin1(Vec<u8>),
      Utf16(Vec<u16>),
      Concatenated(String, String),
  }
Then, when you try to access the string, if it’s Concatenated it’ll flatten it into one of the other representations.

Thus, the += itself becomes cheap, and in typical patterns you only incur the cost of allocating a new string once, when you next try to read from it (including things like JSON.stringify(object_containing_this_string) or element.setAttribute(name, this_string)).

  • masklinn 2 hours ago

    An option you did not mention, although not generally available to languages with advanced runtime, is that even if you have immutable strings you can realloc them if you know you're the only owner of that string (e.g. because they're refcounted, or can't be shared).

    CPython does that, so a trivial concatenation loop is (amortised) linear (causing issues for alternate implementations when they have to run that). Swift might also be able to via COW optimisation.

    Rust's string concatenation is a variant of this (though it has mutable strings anyway): `String::add` takes an owned value on the LHS, and the implementation just appends to the LHS before returning it:

        fn add(mut self, other: &str) -> String {
            self.push_str(other);
            self
        }
    
    so repeated concatenation will realloc and amortize as if you were just `push_str`-ing in a loop (which maps directly to appending to the underlying buffer).
    • chrismorgan 7 minutes ago

      For more technical precision in Rust (not because it actually changes anything), += will use AddAssign rather than Add, if it’s implemented, which mutates in-place, whereas `a = a + b` would move twice (though in a way that will always optimise to the same thing). This means you’re actually invoking

        impl AddAssign<&str> for String {
            #[inline]
            fn add_assign(&mut self, other: &str) {
                self.push_str(other);
            }
        }
      
      which the doc comment notes “has the same behavior as the `push_str` method”.
  • masklinn 4 hours ago

    > As noted a paragraph later, the Java compiler is able to detect and “fix” this, by rewriting the code to use a mutable string.

    Does it actually do that nowadays? Back in my days it was incapable of lifting the builder out of loops, so for each iteration it would instantiate a builder with the accumulator string, append the concatenation, then stringify and reset the accumulator.

    The linked docs don’t say anything about loops.

    • emil-lp 3 hours ago

      I agree. If you append to a string in a loop in Java, you will see quadratic behavior.

  • miki123211 5 hours ago

    > Another solution is to put concatenation into your string type

    Aah, the Erlang way of handling strings.

    On Beam (Erlang's VM), that goes as deep as IO. It's perfectly fine to pass a (possibly nested) list of strings (whether charlists or binaries) to an IO function, and the system just knows how to deal with that.

capitainenemo 10 hours ago

Article claims python 3 uses UTF-8.

https://stackoverflow.com/questions/1838170/ "In Python 3.3 and above, the internal representation of the string will depend on the string, and can be any of latin-1, UCS-2 or UCS-4, as described in PEP 393."

Article also says PHP has immutable strings. They are mutable, although often copied.

Article also claims majority of popular languages have immutable strings. As well as the ones listed there is also PHP and Rust (and C, but they did say C++ - and obviously Ruby since that's the subject of the article).

I'm also a bit surprised by the last sentence. "However, if you do measure a negative performance impact, there is no doubt you are measuring incorrectly." There must surely be programs doing a lot of string building or in-place modification that would benefit from non-frozen.

  • byroot 4 hours ago

    > There must surely be programs doing a lot of string building or in-place modification that would benefit from non-frozen.

    The point is that the magic comment (or the --enable-frozen-string-literal) only applies to literals. If you have some code using mutable strings to iteratively append to it, flipping that switch doesn't change that. It just means you'll have to explicitly create a mutable string. So it doesn't change the performance profile.

  • byroot 4 hours ago

    > can be any of latin-1, UCS-2 or UCS-4, as described in PEP 393

    My bad, I haven't seriously used Python for over 15 years now, so I stand corrected (and will clarify the post).

    My main point stands though, Python strings have an internal representation, but it's not exposed to the user like Ruby strings.

    > Article also says PHP has immutable strings. They are mutable, although often copied.

    Same. Thank you for the correction, I'll update the post.

  • ameliaquining 8 hours ago

    In C, C++, and Rust, the question of "are strings in this language mutable or immutable?" isn't applicable, because those languages have transitive mutability qualifiers. So they only need a single string type, and whether you can mutate it or not depends on context. (C++ and Rust have multiple string types, but the differences among them aren't about mutability.) In languages without this feature, a given value is either always mutable or never mutable, and so it's necessary to pick one or the other for string literals.

  • chrismorgan 8 hours ago

    Python strings aren’t even proper Unicode strings. They’re sequences of code points rather than scalar values, meaning they can contain surrogates. This is incompatible with basically everything: UTF-* as used by sensible things, and unvalidated UTF-16 as used in the likes of JavaScript, Windows wide strings and Qt.

    • nilslindemann 6 hours ago

      But isn't 'surrogateescape' supposed to address this? (no expert)

      https://vstinner.github.io/pep-383.html

      • chrismorgan 2 hours ago

        surrogateescape is something else altogether. It’s a hack to allow non-Unicode file names/environment variables/command line arguments in an otherwise-Unicode environment, by smuggling them through a part of the surrogate range (0x80 to 0xFF → U+DC80 to U+DCFF) which otherwise can’t occur (since it’s invalid Unicode). It’s a cunning hack that makes a lot of sense: they used a design error in one place (Python string representation) to cancel out a design error in another place (POSIX being late to the game on Unicode)!

o11c 12 hours ago

Important information omitted from title: this is for the Ruby language.

kazinator 9 hours ago

It's perfectly fine to have mutable strings in a hash table; just document that the behavior becomes unspecified if keys are mutated while they are in the table.

Make sure the behavior is safe: it won't crash or be exploitable by a remote attacker.

It works especially well in a language that doesn't emphasize mutation; i.e. you don't reach for string mutation as your go-to tool for manipulation.

Explicit "freeze" stuff is an awful thing to foist onto the programmer.

  • lmm 4 hours ago

    > just document that the behavior becomes unspecified if keys are mutated while they are in the table.

    > Make sure the behavior is safe: it won't crash or be exploitable by a remote attacker.

    There is no such thing as unspecified but safe behaviour. Developers who can't predict what will happen will make invalid assumptions which will lead to security vulnerabilities when they are violated.

    • kazinator 3 hours ago

      You can predict unspecified behavior: it gives a range of possibilities which do not include failures like termination, or data corruption.

      The order of evaluation of function arguments in C is unspecified, so every time any function whatsoever is called which has two or more arguments, there is unspecified behavior.

      Same in Scheme!

      A security flaw can be caused by a bug that is built on nothing but 100% specified constructs.

      The construct with unspecified behavior won't in and of itself cause a security problem. The programmer believing that a particular behavior will occur, whereas a different one occurs, can cause a bug.

      The unspecified behaviors of a hash table in the face of modified keys can be spelled out in some detail.

      Example requirements:

      "If a key present in a hash table is modified to an unequal value, it is unspecified whether the entry can be found using the new key; in any case, the entry cannot be found using the old key. If a key present in a hash table is modified to be equal to another key also present in the same hash table, it is unspecified which entry is found using that key. Modification of a key doesn't prevent that key's entry from being visited during a traversal of the hash."

      • lmm 2 hours ago

        > The order of evaluation of function arguments in C is unspecified, so every time any function whatsoever is called which has two or more arguments, there is unspecified behavior.

        Yes, and that's bad! Subsequent languages like Java learned from this mistake.

        > A security flaw can be caused by a bug that is built on nothing but 100% specified constructs.

        Of course. But it's less common.

        > The programmer believing that a particular behavior will occur, whereas a different one occurs, can cause a bug.

        And unspecified behaviour is a major cause of this! Something like Hyrum's Law applies; programmers often believe that a thing will behave the way it did when they tested it.

        > The unspecified behaviors of a hash table in the face of modified keys can be spelled out in some detail.

        That is to say, specified :P. The more you narrow the scope of what is unspecified, the better, yes; and narrowing it to nothing at all is best.

  • ameliaquining 8 hours ago

    In general, Ruby does allow mutable values in hash tables, with basically those semantics: https://docs.ruby-lang.org/en/3.4/Hash.html#class-Hash-label...

    The copy-and-freeze behavior is a special case that applies only to strings, presumably because the alternative was too much of a footgun since programmers usually think of strings in terms of value semantics.

    I don't think anyone likes the explicit .freeze calls everywhere; I think the case for frozen strings in Ruby is primarily based on performance rather than correctness (which is why it wasn't obvious earlier in the language's history that it was the right call), and the reason it's hard to make the default is because of compatibility.

    • kazinator 8 hours ago

      > since programmers usually think of strings in terms of value semantics.

      Can you blame them, when you out of your way to immerse strings in the stateful OOP paradigm, with idioms like "foo".upcase!

      If you give programmers mainly a functional library for string manipulations that returns new values, then that's what they will use.